Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erratic action bar transition when using bound (or empty) title property #2672

Closed
ignaciofuentes opened this issue Sep 2, 2016 · 3 comments
Assignees
Milestone

Comments

@ignaciofuentes
Copy link

ignaciofuentes commented Sep 2, 2016

Tell us about the problem

Erratic action bar transition when using bound (or empty) title property on the Actionbar that is being navigated to

Which platform(s) does your issue occur on?

iOS

Please provide the following version numbers that your issue occurs with:

2.2.1

Please tell us how to recreate the issue in as much detail as possible.

When setting the title of an actionBar to be dataBound the incoming actionBar navigates from the middle of the page up.
Please see this screencast.
My current workaround is to set the details-page to have actionBarHidden set to false.
The same thing happens when there is no ActionBar definition at all in the incoming page. The ActionBar eventually is on the page, but the transition does the same odd middle-up sliding

Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

details-page.xml

<Page xmlns="http://schemas.nativescript.org/tns.xsd" navigatingTo="onNavigatingTo">
  <Page.actionBar>
      <ActionBar title="{{title}}"/>
  </Page.actionBar>
  <StackLayout>
    <Label text="Second page" class="title"/>  
  </StackLayout>
</Page>

details-page.js

function onNavigatingTo(args) {
    var page = args.object;    
    page.bindingContext = {title:"Dynamic title"};
}
exports.onNavigatingTo = onNavigatingTo;
@tsonevn tsonevn self-assigned this Sep 7, 2016
@tsonevn
Copy link
Contributor

tsonevn commented Sep 7, 2016

Hi @ignaciofuentes,

Thank you for reporting this issue.

I was able to reproduce this problem with ActionBar transition in iOS. In regard to that I am attaching link to a sample project where this issue has been reproduced. We will investigate this problem and will provide fix in some of the next NatioveScript versions.

Regards,
@tsonevn

@tsonevn tsonevn removed their assignment Sep 9, 2016
@tzraikov tzraikov self-assigned this Nov 14, 2016
@tzraikov tzraikov added this to the 2.5.0 milestone Nov 15, 2016
@tzraikov tzraikov added ready for test TSC needs to test this and confirm against live production apps and automated test suites and removed in progress labels Nov 15, 2016
@tzraikov
Copy link
Contributor

Will be addressed with #2870

@SvetoslavTsenov SvetoslavTsenov self-assigned this Nov 24, 2016
@SvetoslavTsenov SvetoslavTsenov added done and removed ready for test TSC needs to test this and confirm against live production apps and automated test suites labels Jan 9, 2017
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants