fix: nested fragments interact thru child fragment manager #6293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
manoldonev
force-pushed
the
mdonev/child-fragment-manager-fix
branch
4 times, most recently
from
66045a1 to
45c7a80
Compare
manoldonev
requested review from
ADjenkov,
vakrilov,
MartoYankov and
vchimev
manoldonev
changed the title
ADjenkov
approved these changes
Sep 27, 2018
MartoYankov
reviewed
Sep 27, 2018
| @@ -20,7 +20,7 @@ import { | |||
|
|
|||
| import { Background, ad as androidBackground } from "../../styling/background"; | |||
| import { profile } from "../../../profiling"; | |||
| import { topmost } from "../../frame/frame-stack"; | |||
| import { topmost } from "../../frame"; | |||
There was a problem hiding this comment.
If I remember correctly, the reason for the separate frame-stack file and import was to avoid circular dependencies. Is this problem fixed now?
There was a problem hiding this comment.
Not sure but I'll revert that.
MartoYankov
reviewed
Sep 27, 2018
| // - tabview -> frame1 (frame1 uses tabview item CHILD fm) | ||
| // - frame1 -> tabview (tabview uses frame1 CHILD fm) | ||
| // - frame1 -> tabview -> frame2 (tabview uses frame1 CHILD fm; frame2 uses tabview item CHILD fm) | ||
| if (view.typeName === "Frame" || view.typeName === "TabView") { |
There was a problem hiding this comment.
I think the typeName will be wrong (and won't work) with uglify. The other property cssType that is set via the decorator might work, but it doesn't look right to use it.
What do you think about having a method _hasFragments() that returns true for TabView and Frame ?
manoldonev
force-pushed
the
mdonev/child-fragment-manager-fix
branch
3 times, most recently
from
be7c007 to
9831312
Compare
manoldonev
force-pushed
the
mdonev/child-fragment-manager-fix
branch
from
858ef79 to
0e498a7
Compare
MartoYankov
approved these changes
Oct 9, 2018
manoldonev
force-pushed
the
mdonev/child-fragment-manager-fix
branch
from
407bcd9 to
abc3f1c
Compare
manoldonev
force-pushed
the
mdonev/child-fragment-manager-fix
branch
from
29b533b to
bf0865a
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6292
TODO: review tab fragments' logic with respect to this change (and how did it work so far in the first place).