Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): disable default tab reselect behavior #6968

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

MartoYankov
Copy link
Contributor

@MartoYankov MartoYankov commented Feb 27, 2019

PR Checklist

What is the current behavior?

On iOS by default the TabView resets the navigation in a single tab when the tab is re-selected. This breaks navigation as it's not handled by NS.

What is the new behavior?

This behavior is disabled.

Fixes NativeScript/nativescript-angular#1466

@MartoYankov MartoYankov self-assigned this Feb 27, 2019
@cla-bot cla-bot bot added the cla: yes label Feb 27, 2019
@ghost ghost added the in progress label Feb 27, 2019
@MartoYankov
Copy link
Contributor Author

test package_version#latest

@vakrilov
Copy link
Contributor

AFAIU, this is a problem only with Angular as the native navigation gets out of sync with the Angular navigation.
Is it possible to make a property disabling the re-select tab feature and use it for Angular?

@MartoYankov
Copy link
Contributor Author

There are several points to be made here:

  1. This actually breaks the Core framework too, but it's not that obvious. If you navigate several times and reselect the tab, it will reset the Frame to the root view controller and it's UI will work, but we haven't cleared the Frame history stack, so if you call goBack() it will break.
  2. Making this a property and integrating it in Angular would make this more a feature than a patch. We should probably do this separately.

@MartoYankov MartoYankov merged commit 043cbf3 into release Mar 1, 2019
@MartoYankov MartoYankov deleted the myankov/disable-tab-reselect branch March 1, 2019 09:18
@ghost ghost removed the in progress label Mar 1, 2019
MartoYankov added a commit that referenced this pull request Mar 5, 2019
fix(ios): disable default tab reselect behavior (#6968)
@lock
Copy link

lock bot commented Feb 29, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants