fix(connectivity): getActiveNetworkInfo and NetworkInfo modern compliance #8580

[triniwiz]

No description provided.

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @triniwiz.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

[NathanWalker]

iOS changes lgtm - @NathanaelA can approve android changes.

[triniwiz]

Existing apps using the connectivity module will need to add the following to the AndroidManifest.xml which should be located in app/App_Resources/Android/src/main/AndroidManifest.xml

<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>

[farfromrefug]

If i may jump in. I think it would be best not to use the extend syntax (android NetworkCallback). But to use constructor implementation instead. Same behavior behind but in a sense it is more readable (typings) as not seen as class extension. Also it allows to pass object for which instance methods can be used as implementation. Means it prevents instantiating functions everytime.
Finally you should use method shorthands for the methods definitions for NetworkCallback. Like 'onUnvailable:notifyCallback'

[farfromrefug]

@triniwiz as we discussed yesterday, extendis the best way to go as it could be the same syntax on iOS.
Rest the point about not creating funcs every time
And using extend it means you should store the newly created class for later use.

[NathanWalker]

Released with https://github.com/NativeScript/NativeScript/releases/tag/6.5.9 now