Skip to content

Commit

Permalink
fix(action bar): attach #comment nodes with _addView (#729)
Browse files Browse the repository at this point in the history
#comment nodes should be added as views to 'actionBar' since they are anchors for the elements added by structural directive (*ngIf, *ngFor, etc.)

closes #725
  • Loading branch information
sis0k0 committed Mar 30, 2017
1 parent c6f7549 commit 0490605
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions nativescript-angular/directives/action-bar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import { Page } from "tns-core-modules/ui/page";
import { View } from "tns-core-modules/ui/core/view";
import { registerElement, ViewClassMeta, NgView } from "../element-registry";

let actionBarMeta: ViewClassMeta = {
const actionBarMeta: ViewClassMeta = {
skipAddToDom: true,
insertChild: (parent: NgView, child: NgView, _atIndex: number) => {
insertChild: (parent: NgView, child: NgView, atIndex: number) => {
const bar = <ActionBar>(<any>parent);
const childView = <any>child;

Expand All @@ -17,13 +17,16 @@ let actionBarMeta: ViewClassMeta = {
} else if (child instanceof ActionItem) {
bar.actionItems.addItem(childView);
childView.parent = bar;
} else if (child.nodeName !== "#text" && child instanceof View) {
} else if (child.nodeName === "#comment") {
bar._addView(childView, atIndex);
} else if (child instanceof View) {
bar.titleView = childView;
}
},
removeChild: (parent: NgView, child: NgView) => {
const bar = <ActionBar>(<any>parent);
const childView = <any>child;

if (child instanceof NavigationButton) {
if (bar.navigationButton === childView) {
bar.navigationButton = null;
Expand Down

0 comments on commit 0490605

Please sign in to comment.