Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModalDialogService.showModal() doesn't show modal #273

Closed
vakrilov opened this issue Jun 6, 2016 · 1 comment · Fixed by #274
Closed

ModalDialogService.showModal() doesn't show modal #273

vakrilov opened this issue Jun 6, 2016 · 1 comment · Fixed by #274
Labels
Milestone

Comments

@vakrilov
Copy link
Contributor

vakrilov commented Jun 6, 2016

Issue is reproduced here.

It happens when the following conditions are true:

  • showModal() is used in a component that has its change detection strategy set to onPush.
  • showModal() is called from an async callback (e.x. setTimeout())
@vakrilov
Copy link
Contributor Author

vakrilov commented Jun 6, 2016

The problem is that when CD strategy is set onPush - we should trigger change detection manually when dynamically loading component (when loading the modal content).

@vakrilov vakrilov added the bug label Jun 6, 2016
@vakrilov vakrilov added this to the NS 2.1 milestone Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant