refactor: stop exporting NativeScriptModule from platform #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdeshev
approved these changes
Mar 14, 2017
Importing NativeScriptModule from "nativescript-angular/platform" leads to
including @angular/compiler in the bundle when doing AoT compilation
with webpack. Import from "nativescript-angular/nativescript.module"
should be used instead.
BREAKING CHANGE: User applications cannot import NativeScriptModule from
"nativescript-angular/platform" anymore.
Migration:
Before:
```
import { NativeScriptModule } from "nativescript-angular/platform";
```
After
```
import { NativeScriptModule } from
"nativescript-angular/nativescript.module";
```
sis0k0
force-pushed
the
remove-nsmodule-export
branch
from
bd8e0e1 to
64017fa
Compare
sis0k0
added a commit
that referenced
this pull request
Mar 21, 2017
Importing NativeScriptModule from "nativescript-angular/platform" leads to
including @angular/compiler in the bundle when doing AoT compilation
with webpack. Import from "nativescript-angular/nativescript.module"
should be used instead.
BREAKING CHANGE: User applications cannot import NativeScriptModule from
"nativescript-angular/platform" anymore.
Migration:
Before:
```
import { NativeScriptModule } from "nativescript-angular/platform";
```
After
```
import { NativeScriptModule } from
"nativescript-angular/nativescript.module";
```
sis0k0
added a commit
that referenced
this pull request
Mar 22, 2017
Importing NativeScriptModule from "nativescript-angular/platform" leads to
including @angular/compiler in the bundle when doing AoT compilation
with webpack. Import from "nativescript-angular/nativescript.module"
should be used instead.
BREAKING CHANGE: User applications cannot import NativeScriptModule from
"nativescript-angular/platform" anymore.
Migration:
Before:
```
import { NativeScriptModule } from "nativescript-angular/platform";
```
After
```
import { NativeScriptModule } from
"nativescript-angular/nativescript.module";
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing NativeScriptModule from "nativescript-angular/platform" leads to
including @angular/compiler in the bundle when doing AoT compilation
with webpack. Import from "nativescript-angular/nativescript.module"
should be used instead.
BREAKING CHANGE: User applications cannot import NativeScriptModule from
"nativescript-angular/platform" anymore.
Migration:
Before:
After