feat(animations): introduce NativeScriptAnimationsModule #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also introduce new NativeScriptAnimationsEngine that extends DomAnimationsEngine and overrides methods that work with DOM tree. BREAKING CHANGE: To use animations, you need to import the NativeScriptAnimationsModule from "nativescript-angular/animations" in your root NgModule.
Needed to properly implement browser's DomAdapter. Caused by: angular/angular@a4076c7
revert after this fix: angular/angular#15300
sis0k0
added a commit
that referenced
this pull request
Mar 20, 2017
same as #704 but using modules 2.5 style properties API's
sis0k0
added a commit
that referenced
this pull request
Mar 20, 2017
same as #704 but using modules 2.5 style properties API's
sis0k0
added a commit
that referenced
this pull request
Mar 21, 2017
BREAKING CHANGE: To use animations, you need to import the NativeScriptAnimationsModule from "nativescript-angular/animations" in your root NgModule.
sis0k0
added a commit
that referenced
this pull request
Mar 21, 2017
BREAKING CHANGE: To use animations, you need to import the NativeScriptAnimationsModule from "nativescript-angular/animations" in your root NgModule.
sis0k0
added a commit
that referenced
this pull request
Mar 22, 2017
same as #704 but using modules 2.5 style properties API's BREAKING CHANGE: To use animations, you need to import the NativeScriptAnimationsModule from "nativescript-angular/animations" in your root NgModule. Also you need a dependency to "@angular/animations".
sis0k0
added a commit
that referenced
this pull request
Mar 23, 2017
BREAKING CHANGE: To use animations, you need to import the NativeScriptAnimationsModule from "nativescript-angular/animations" in your root NgModule.
hdeshev
pushed a commit
that referenced
this pull request
Mar 28, 2017
BREAKING CHANGE: To use animations, you need to import the NativeScriptAnimationsModule from "nativescript-angular/animations" in your root NgModule.
hdeshev
pushed a commit
that referenced
this pull request
Mar 28, 2017
BREAKING CHANGE: To use animations, you need to import the NativeScriptAnimationsModule from "nativescript-angular/animations" in your root NgModule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also introduce new NativeScriptAnimationsEngine that extends DomAnimationsEngine and overrides methods that work with DOM tree.
BREAKING CHANGE: To use animations, you need to import the
NativeScriptAnimationsModule from "nativescript-angular/animations" in
your root NgModule.