feat: Angular 4.2 support #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when will this PR merged ? |
sis0k0
force-pushed
the
vlaeva/ng-4.2
branch
5 times, most recently
from
066dbb6 to
60a3d2b
Compare
sis0k0
force-pushed
the
vlaeva/ng-4.2
branch
4 times, most recently
from
e99e653 to
4264360
Compare
sis0k0
force-pushed
the
vlaeva/ng-4.2
branch
2 times, most recently
from
d34de2a to
9580038
Compare
sis0k0
changed the title
- don't run change detection every time an outlet is activated - drop `routerOutletMap`s caused by angular/angular#16510
All common providers, such as CommonModule (from @angular/common), Frame, Page, Device and Modals are moved from NativeScriptModule to NativeScriptCommonModule. It can be required from "nativescript-angular/common". The NativeScriptRouterModule also imports the common module now. Importing NativeScriptModule more than once causes reinstantiating of the NativeScriptRenderer, which breaks animations. BREAKING CHANGES: NativeScriptModule should be imported only in the root application module (usually named AppModule). It provides essential the Renderer, ModuleLoader and exports the ApplicationModule. All other NgModules in the app (both feature and lazy-loaded ones) should import the NativeScriptCommonModule instead. The behaviour is alligned with BrowserModule and CommonModule in web Angular apps. https://angular.io/guide/ngmodule-faq#q-browser-vs-common-module
This was referenced Jul 22, 2017
|
Still waiting for a merge.... Nice one @sis0k0 |
vakrilov
approved these changes
Jul 26, 2017
nativescript-angular/tslint.json
Outdated
| @@ -57,7 +57,7 @@ | |||
| "no-empty": false, | |||
| "no-eval": true, | |||
| "no-null-keyword": false, | |||
| "no-shadowed-variable": true, | |||
| "no-shadowed-variable": false, | |||
There was a problem hiding this comment.
Is there a reason to disable this rule?
Tslint was OK locally when I enabled it back again
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #786