Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] Improve livesync performance for iOS #1727

Closed
vchimev opened this issue Apr 27, 2016 · 6 comments
Closed

[Angular] Improve livesync performance for iOS #1727

vchimev opened this issue Apr 27, 2016 · 6 comments
Assignees
Milestone

Comments

@vchimev
Copy link

vchimev commented Apr 27, 2016

Improve the performance of livesync for iOS, particularly for typescript/angular2 apps.

@rosen-vladimirov rosen-vladimirov added this to the 2.1 (Under consideration) milestone May 26, 2016
@dtopuzov dtopuzov changed the title Improve livesync performance for iOS [Angular] Improve livesync performance for iOS Jun 1, 2016
@dtopuzov
Copy link
Contributor

dtopuzov commented Jun 1, 2016

Angular livesync is slow because it always restart the app.

@rosen-vladimirov
Copy link
Contributor

The problem with angular apps is that they are using TypeScript. When any .ts file is changed, TypeScript watcher transpiles all .ts files to .js files. When this happens, CLI detects all .js files as modified. In fact only one of them is really modified. For Android we are using the shasums of each file, and when we detect change, we calculate the new shasum of the "modified" file and compare it with the shasum of the same file on the device. In case they match, we do not livesync the file.
When you stop the livesync --watch process, apply some changes in your code and call livesync --watch again, CLI will send only the modified files, not the full app (again changes are based on shasums of the files).
We should do the same for iOS, this will speed up the process of livesyncing not only Angular apps, it will boost the livesync of all huge applications.

@NathanWalker
Copy link
Contributor

This would be very helpful @rosen-vladimirov. I've currently been struggling a bit with debugging a {N} + ng2 app I'm working on due to livesync performance being a bit slow here.

@sipacate
Copy link

sipacate commented Jun 2, 2016

I've noticed it's pretty slow also with Android so I don't think this ticket should be limited to iOS.

@enchev
Copy link
Contributor

enchev commented Jun 3, 2016

Hey @sipacate,

Are you using our latest version (2.0.1)?

@enchev enchev assigned enchev and PanayotCankov and unassigned enchev Jun 7, 2016
@enchev enchev added the bug label Jun 13, 2016
@enchev
Copy link
Contributor

enchev commented Jun 21, 2016

We've managed to improve the performance with these pull requests:
#1858
telerik/mobile-cli-lib#719
NativeScript/ios-jsc#584

@enchev enchev closed this as completed Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants