Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare does not flatten scoped dependencies #2177

Closed
dtopuzov opened this issue Oct 31, 2016 · 1 comment
Closed

Prepare does not flatten scoped dependencies #2177

dtopuzov opened this issue Oct 31, 2016 · 1 comment
Assignees
Milestone

Comments

@dtopuzov
Copy link
Contributor

Before we flattened scoped dependencies, now with {N} 2.4 rc we don’t.

Before:
TNS_App/platforms/android/src/main/assets/app/tns_modules/@angular/core
Now:
TNS_App/platforms/android/src/main/assets/app/tns_modules/nativescript-angular/node_modules/@angular/core

Possible implications:
File paths too long for Windows OS.

@dtopuzov dtopuzov added the bug label Oct 31, 2016
@Plamen5kov Plamen5kov self-assigned this Oct 31, 2016
@tsonevn tsonevn added this to the 2.5.0 milestone Dec 5, 2016
@Plamen5kov
Copy link
Contributor

This is expected since cli uses npm installed on machine, if npm 3.x is installed on the user machine, the modules will be flattened if there are no semver exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants