Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeScript CLI on OSX appends data into .bash_profile and corrupts core unix apps.... open #260

Closed
diverted247 opened this issue Feb 27, 2015 · 6 comments
Assignees
Labels
Milestone

Comments

@diverted247
Copy link

After installing NativeScript CLI, the 'open' command stopped functioning and returned "Trace/BPT trap: 5" with many calls. I traced this back to functions injected into .bash_profile that were linked to NativeScript.

Far from ideal.

@teobugslayer
Copy link
Contributor

Hello @diverted247,

This is a know issue which we could not fix for the upcoming release next week. The work around is to open another terminal console or to manually fix the COMP_WORDBREAKS environment variable.

That said, if you can fix this issue, feel free to send us a pull request against https://github.com/Icenium/node-tabtab .

@diverted247
Copy link
Author

This just went from bad to pathetic.
So Telerik is "ok" shipping something "known" to corrupt the terminal environment on OSX/Linux.

Uninstall...

@rosen-vladimirov
Copy link
Contributor

Hi @diverted247
We've applied a fix in our node-tabtab repository that should fix the problem. Please note that the code in tabtab is forked from npm itself. As you can see here: https://github.com/npm/npm/blob/master/lib/utils/completion.sh#L10
COMP_WORDBREAKS variable is reset by npm itself. Our code just adds the change to .bashrc and .bash_profile in order to allow completion of commands and options. On some systems this is causing errors as COMP_WORDBREAKS variable receives incorrect value.
Anyway we've removed the code that exports the variable from .bashrc and .bash_profile, so you can try installing latest nativescript-cli version and see if you still receive "Trace/BPT trap: 5" errors.
Hope this helps.

@spacepluk
Copy link

While I'm not as annoyed as @diverted247, I agree that it's not ok to mess with people's dotfiles without at least giving a warning. I'd prefer enabling autocompletion as an extra manual step of the installation.

Just my 2cents.
Now back to try this, it looks awesome :P

@rosen-vladimirov
Copy link
Contributor

Hi @spacepluk,
Thank you for the valuable feedback. As I've said - we've removed the part of the code, which was causing this error. However we find your idea to enable auto completion only in case the user accepts it, very interesting and we'll definitely consider improvements in this area.

@rosen-vladimirov
Copy link
Contributor

Hi @spacepluk, @diverted247,
I just want to update you on this case. Base on your feedback we've decided to ask the user for confirmation before writing to .bash_profile and .bashrc files. This behavior is already part of the master branch, so you can give it a try immediately.
I'm closing this thread now, the related one for the feature implementation is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants