Increase the default timeout for debug command from 5 to 10 seconds #3752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…econds. Add support for --timeout option that can be passed to debug command. Fix help of debug command.
ivanovit
approved these changes
Jul 16, 2018
DimitarTachev
approved these changes
Jul 16, 2018
|
|
||
| private getTimeout(debugOptions: IDebugOptions): number { | ||
| let timeout = parseInt(debugOptions && debugOptions.timeout, 10); | ||
| if (!timeout) { |
There was a problem hiding this comment.
Do we want to fallback to 10 secs if the user passes 0? I will expect an infinite wait if I pass 0.
Fatme
force-pushed
the
fatme/timeout-debug
branch
from
7a37444 to
62b01dd
Compare
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for --timeout option that can be passed to debug command.
Fix help of debug command.
PR Checklist
What is the current behavior?
The default timeout for
debug ioscommand is 5 seconds.What is the new behavior?
The default timeout for
debug ioscommand is 10 seconds. Also adds support for--timeoutoption.