Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] tns preview is including tns-core-modules in vendor.js #4658

Closed
DimitarTachev opened this issue May 31, 2019 · 0 comments
Closed

[iOS] tns preview is including tns-core-modules in vendor.js #4658

DimitarTachev opened this issue May 31, 2019 · 0 comments
Assignees
Labels
bug os: ios preview Describes issues related to preview command webpack
Milestone

Comments

@DimitarTachev
Copy link
Contributor

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 5.4.0
  • Cross-platform modules:5.4.0
  • Android Runtime:5.4.0
  • iOS Runtime:5.4.0
  • Plugin(s): dev-webpack: 0.24.0

Describe the bug
With tns preview, the production dependencies of the Preview app are marked as external modules and excluded from vendor.js in order to be used from the Preview app itself.

However, when scanning on iOS, the tns-core-modules are included in vendor.js. The reason for this behavior is the additional inspector-modules iOS entry point which is an entry point from an external module. The file contains relative requests to other files inside tns-core-modules and our externals logic is not detecting them.

To Reproduce

  1. tns create jsApp --js && cd jsApp
  2. tns preview
  3. Scan with iOS device
  4. Take a look at ./platforms/ios/jsApp/app/vendor.js.

Expected behavior
The file must be a few hundred lines containing only the runtime part of some dev-dependencies but it's containing the whole tns-core-modules module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug os: ios preview Describes issues related to preview command webpack
Projects
None yet
Development

No branches or pull requests

3 participants