Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support V8 Snapshots on Windows #5107

Closed
DimitarTachev opened this issue Sep 26, 2019 · 1 comment
Closed

Support V8 Snapshots on Windows #5107

DimitarTachev opened this issue Sep 26, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@DimitarTachev
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The --env.snapshot flag is not supported and throwing an exception on Windows.

Describe the solution you'd like
As we already have snapshots generation in a Docker container for macOS Catalina, we could reuse the same approach on Windows.

@DimitarTachev DimitarTachev self-assigned this Sep 26, 2019
@endarova
Copy link
Contributor

endarova commented Oct 15, 2019

Acceptance criteria:

  • when executing build with --env.snapshot flag on windows, a Docker usage message should be shown
  • when executing build with --env.snapshot flag on windows without Docker, the process should exit with a Docker installation error
  • when executing build with --env.snapshot flag on windows without running Docker server, the process should exit with a missing Docker server error
  • when executing build with --env.snapshot flag on windows with running Docker server, the command should run successfully without any additional actions.
  • with nativescript@6.1 and nativescript-dev-webpack@1.2.1 and earlier when executing build with --env.snapshot flag on windows message that snapshot flag is skipped should be shown

@rosen-vladimirov rosen-vladimirov transferred this issue from NativeScript/nativescript-dev-webpack Nov 1, 2019
@Fatme Fatme added the feature label Nov 1, 2019
@Fatme Fatme added this to the 6.2.0 milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants