Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tns update should handle scoped packages #5149

Closed
1 task
KristianDD opened this issue Nov 19, 2019 · 0 comments · Fixed by #5148
Closed
1 task

tns update should handle scoped packages #5149

KristianDD opened this issue Nov 19, 2019 · 0 comments · Fixed by #5148
Assignees
Labels
Milestone

Comments

@KristianDD
Copy link
Contributor

KristianDD commented Nov 19, 2019

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI:

  • Cross-platform modules:

  • Android Runtime:

  • iOS Runtime:

  • Plugin(s):

  • Node.js:

  • Please, attach your package.json and webpack.config.js as these configurations are usually critical for investigating issues with webpack

Describe the bug
tns update won't update the @nativescript/core package if present in the projects` dependencies.

To Reproduce

1 tns create scopeTest --ts
2 npm i --save-exact "@nativescript/core@6.2.0"
3 tns update

Expected behavior
@nativescript/core to be updated to the version present in the template with the same major and minor and maximum patch version as the CLI. For example if the CLI is 6.2.0 we expect the version from template satisfying version ~6.2.0

Sample project

Additional context

@KristianDD KristianDD self-assigned this Nov 19, 2019
@KristianDD KristianDD added the bug label Nov 19, 2019
@KristianDD KristianDD added this to the 6.3.0 milestone Nov 19, 2019
@KristianDD KristianDD reopened this Nov 20, 2019
@endarova endarova closed this as completed Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants