Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--justlaunch flag enables HMR #5173

Closed
rosen-vladimirov opened this issue Dec 3, 2019 · 0 comments
Closed

--justlaunch flag enables HMR #5173

rosen-vladimirov opened this issue Dec 3, 2019 · 0 comments
Assignees
Labels
bug run Describes issues related to run command
Milestone

Comments

@rosen-vladimirov
Copy link
Contributor

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 6.2.2
  • Cross-platform modules: Not applicable
  • Android Runtime: Not applicable
  • iOS Runtime: Not applicable
  • Plugin(s): Not applicable

Describe the bug
When tns run <platform> --justlaunch is used, the HMR is enabled, which slows down the whole operation. justlaunch is designed to run the application and exits the command, so there's no point of waiting for HMR generation when this flag is provided.

To Reproduce
Run tns run <platform> --justlaunch in any application and check the generated bundle.js - it will have HMR code in it.

Expected behavior
HMR should not be enabled when --justlaunch is used.

Sample project

Additional context

@rosen-vladimirov rosen-vladimirov added bug run Describes issues related to run command labels Dec 3, 2019
@rosen-vladimirov rosen-vladimirov added this to the 6.3.0 milestone Dec 3, 2019
@rosen-vladimirov rosen-vladimirov self-assigned this Dec 3, 2019
@rosen-vladimirov rosen-vladimirov changed the title --justlaunch enables hmr --justlaunch flag enables HMR Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug run Describes issues related to run command
Projects
None yet
Development

No branches or pull requests

2 participants