-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to ignore native dependencies #5524
Conversation
Along with that we simply need to have a cli parameter and an option in nativescript.config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but to stay consistent with the other "types of dependencies", I'd rename the property to ignoredDependencies
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
Co-authored-by: Igor Randjelovic <rigor789@gmail.com>
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
I'm thinking of adding the I'm also thinking we should probably only ignore them in release/production builds - does that make sense, or is there a case where we'd like to ignore them in debug builds too? |
@rigor789 I am ok with ignoring them only in production if used through |
Along with that we simply need to have a cli parameter and an option in nativescript.config
@rigor789 could you help with the cli params? not sure where to do that.
Also i think we could even add ignored dependencies through the webpack config right? I dont remember how but we can modify the project data from there?
With this people can simply make it so that some deps are only used in dev (like vue-dev-tools and socketio) while not being present in production.
You can also make different releases for Google Play and Fdroid (what i am going for) where one would use non open source libs and the other would not (flavors on android)