Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support livesync in remote machine #5560

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

edusperoni
Copy link
Collaborator

@edusperoni edusperoni commented Aug 8, 2021

adds support to wsl via export LIVESYNC_ADDR=hostIpAddr

PR Checklist

What is the current behavior?

livesync always tries to connect to localhost

What is the new behavior?

you can provide the LIVESYNC_ADDR to override the default ip address for livesync

Implements #5450.

adds support to wsl via `export LIVESYNC_ADDR=hostIpAddr`
@cla-bot cla-bot bot added the cla: yes label Aug 8, 2021
Copy link
Member

@rigor789 rigor789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would rename the env var to NATIVESCRIPT_LIVESYNC_ADDRESS to be explicit (I've done a similar env variable on a separate PR for config handling)

lib/services/livesync/android-device-livesync-service.ts Outdated Show resolved Hide resolved
lib/services/livesync/android-livesync-tool.ts Outdated Show resolved Hide resolved
@rigor789 rigor789 added this to the 8.1 milestone Aug 11, 2021
@rigor789 rigor789 merged commit 4e94ad4 into NativeScript:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants