Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more informative android compile SDK messages #5697

Merged

Conversation

delaneyb
Copy link
Contributor

@delaneyb delaneyb commented Nov 2, 2022

PR Checklist

What is the current behavior?

image

CLI produces an incorrect error message that does not indicate that the reason for being unable to find a compatible android SDK version has anything to do with the range of android SDK versions which are interoperable with your current android runtime version. This will leave the user confused if they have a newer android SDK version installed than the most recent one (especially when the CLI is currently telling them to install "version x or later") which is compatible with their current android runtime version e.g. @nativescript/android version 8.1.1 + Android SDK version 31.

What is the new behavior?

image

The error message produced when unable to find an Android SDK version compatible with your android runtime version will list out the android SDK versions compatible with your runtime version, and specifically mention Supported targets vary based on what android runtime you have installed. Currently your app uses @nativescript/android x.x.x

@cla-bot cla-bot bot added the cla: yes label Nov 2, 2022
@rigor789 rigor789 merged commit cfaa882 into NativeScript:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants