Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly merge IPHONEOS_DEPLOYMENT_TARGET in xcconfigs #5728

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

When using xcodeproj merge, it'll merge properties like:

// file 1
IPHONEOS_DEPLOYMENT_TARGET= 10.0;
// file 2
IPHONEOS_DEPLOYMENT_TARGET= 14.0;

//output
IPHONEOS_DEPLOYMENT_TARGET= 10.0; 14.0;

This causes an issue with Xcode 14.3 where this property is now being set for plugins as well

What is the new behavior?

If both configs have IPHONEOS_DEPLOYMENT_TARGET, then we override instead of append

Fixes triniwiz/nativescript-plugins#176

@cla-bot cla-bot bot added the cla: yes label Apr 11, 2023
@rigor789 rigor789 changed the title fix: xcode 14.3 appending IPHONEOS_DEPLOYMENT_TARGET instead of replacing it fix: correctly merge IPHONEOS_DEPLOYMENT_TARGET in xcconfigs Apr 12, 2023
@rigor789 rigor789 merged commit e6c09c0 into main Apr 12, 2023
@rigor789 rigor789 deleted the fix/xcode-14-3-deployment-version branch April 12, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants