Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): fix the generation of the autocomplete script and prevent duplication on enable/disable #5794

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

jcassidyav
Copy link
Contributor

PR Checklist

What is the current behavior?

The command ns autocomplete enable doesn't work in the current version as the incorrect command is called to yargs to generate the script.

In addition the yargs script doesn't seem to work with the commands ns tns.

Also the existing script duplicates the contents of .tnsrc on enable/disable and it does not clean up what the previous implementation did.

What is the new behavior?

This should now implement ns autocomplete enable/disable so that it works for ns/tns as you would expect.
It cleans up the previous implementation and does not duplicate entries in .tnsrc on repeated enable/disable.

@cla-bot cla-bot bot added the cla: yes label Mar 12, 2024
@rigor789 rigor789 self-assigned this Mar 13, 2024
@rigor789 rigor789 merged commit 7c87b49 into NativeScript:main Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants