Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

Comments

@jessorlisa
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I am working on a NativeScript Angular project and I am confused about the dev dependencies. When I update the dev dependencies a fixed dependency of @angular/compiler-cli@8.2.0 is added
Output:

$ ./node_modules/.bin/update-ns-webpack --deps
Updating dev dependencies...
Adding dev dependency: @angular/compiler-cli@8.2.0

Updating the dev dependencies for @nativescript/angular results in a less strict requirement:

$ ./node_modules/.bin/update-app-ng-deps
[...]
Updated dependency @angular/compiler-cli to version: ~8.2.0.

Everything seems to be working fine with the latter.

Describe the solution you'd like
$ ./node_modules/.bin/update-ns-webpack --deps adds the same dependencies as $ ./node_modules/.bin/update-app-ng-deps (it does not matter which one).

Describe alternatives you've considered
Ignoring the discrepancy ;)

Additional context

$ tns info
✔ Getting NativeScript components versions information...
✔ Component nativescript has 6.3.1 version and is up to date.
✔ Component @nativescript/core has 6.3.2 version and is up to date.
✔ Component tns-android has 6.3.1 version and is up to date.
✔ Component tns-ios has 6.3.0 version and is up to date.
$ npm ls nativescript-dev-webpack
└── nativescript-dev-webpack@1.4.1 
@rosen-vladimirov
Copy link
Contributor

rosen-vladimirov commented Jan 13, 2020

Hey @jessorlisa ,
Thanks for pointing this difference. The code for updating dependencies via update-ns-webpack script is available here. Maybe you can send us a PR to resolve this issue?

@jessorlisa
Copy link
Contributor Author

Sure, here you go.

@dtopuzov
Copy link
Contributor

Fix is already available in nativescript-dev-webpack@next.
Will be officially released with nativescript-dev-webpack@1.5.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.