This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
fix(compiler): reject promise with real error #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the webpack compiler fails, the error is not used in the rejection, so the promise is always rejected with `undefined`. Fix this by respecting the error. Construct real error object as well.
rosen-vladimirov
requested review from
PanayotCankov,
Mitko-Kerezov and
sis0k0
sis0k0
approved these changes
Dec 13, 2017
In case we want to use webpack, force the build by setting nativeChanged property of changesInfo to true. This is TEMP solution until we have a better one.
vchimev
approved these changes
Dec 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the webpack compiler fails, the error is not used in the rejection, so the promise is always rejected with
undefined.Fix this by respecting the error. Construct real error object as well.
Force rebuild of application when webpack is used …
In case we want to use webpack, force the build by setting nativeChanged property of changesInfo to true.
This is TEMP solution until we have a better one.
Fixes #340