This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
fix: bundling of Angular apps using linked TS plugins #505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
When you try to build the Angular demo of a plugin and the plugin source is linked in the demo, you will receive the following exception:
and even if you include the problematic
demo-angular/node_modules/nativescript-your-plugin/your-plugin.ts
file using thefiles
orinclude
tsconfig properties as described in the exception message, you will still get the same error because the file is linked and this is not its real location.What is the new behavior?
When you try to build the Angular demo of a plugin and the plugin source is linked in the demo, you will receive the following exception:
and when you include the problematic
src/your-plugin.ts
file using thefiles
orinclude
tsconfig properties as described in the exception message, you will get the app built and running.Why in Angular apps only?
It seems that the
@ngtools/webpack
typescript loader used in the Angular apps requires real paths to the ts files, while theawesome-typescript-loader
used in the Typescript NativeScript apps is working fine with the linked paths.