Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

feat(Vue): add support for TypeScript #734

Merged
merged 3 commits into from
Dec 11, 2018
Merged

feat(Vue): add support for TypeScript #734

merged 3 commits into from
Dec 11, 2018

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Dec 10, 2018

About

This PR adds support for TypeScript in the Vue template. The ts-loader is used for transpiling files with .ts extension and TS code inside SFCs.
Check out the demo application.

Plugin development

The resolving of symlinked packages is turned on. This will allow the development of TS plugins that are linked in some demo application. For example, nativescript-ui-listview.

@sis0k0 sis0k0 requested review from bundyo and zbranzov December 10, 2018 17:59
Add `awesome-typescript-loader` to the webpack configuration for vue
projects.
The `ts-loader` for webpack is used for transpiling TS in Vue projects.
The `ts-loader` works for Single File Components, whereas the
`awesome-typescript-loader` does not.
@zbranzov zbranzov merged commit d290515 into master Dec 11, 2018
@zbranzov zbranzov deleted the sis0k0/ts-vue branch December 11, 2018 13:38
@@ -74,30 +74,31 @@
"generate-android-snapshot": "./bin/generate-android-snapshot"
},
"dependencies": {
"@angular-devkit/core": "~7.1.0",
"awesome-typescript-loader": "~5.2.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can remove this now :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still used in the webpack config for {N} + TypeScript apps. I will try to migrate that config to ts-loader as well and remove the awesome-typescript-loader.

"clean-webpack-plugin": "~1.0.0",
"copy-webpack-plugin": "~4.6.0",
"css-loader": "~1.0.0",
"extract-text-webpack-plugin": "~3.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one wasn't working with Webpack 4, does it now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It doesn't work and it is not used in the configs anymore. I will remove it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants