Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and add RockPi support #45

Closed
marvinmarnold opened this issue Aug 26, 2021 · 0 comments · Fixed by #59
Closed

Refactor and add RockPi support #45

marvinmarnold opened this issue Aug 26, 2021 · 0 comments · Fixed by #59
Assignees
@marvinmarnold
Labels
enhancement New feature or request
Milestone
Sprint 1

Comments

@marvinmarnold
Copy link
Contributor

marvinmarnold commented Aug 26, 2021 •
edited
Loading

Notes

  • Move logic to hm-pyhelper, where appropriate.
  • Need consistency in how repos are structured.
  • Why are we using sed?
  • Can potentially be rewritten to bash.

Acceptance criteria

  • Use python logging instead of print statements
  • No camelCasing
  • Same code should work for RaspberryPi and RockPi
@marvinmarnold marvinmarnold added this to the Sprint 1 milestone Aug 26, 2021
@marvinmarnold marvinmarnold added the enhancement New feature or request label Sep 20, 2021
@marvinmarnold marvinmarnold changed the title Refactor Refactor and add RockPi support Sep 30, 2021
@marvinmarnold marvinmarnold self-assigned this Oct 4, 2021
@marvinmarnold marvinmarnold mentioned this issue Oct 5, 2021
Merged
@shawaj shawaj mentioned this issue Oct 8, 2021
Open
@marvinmarnold marvinmarnold mentioned this issue Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvinmarnold marvinmarnold

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging a pull request may close this issue.

Refactor build process NebraLtd/hm-pktfwd
1 participant
@marvinmarnold