-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pattern '${base64:JHtqbmRp' #21
Comments
Oh, yes - from my own rule ... thanks |
Oh, no, it's already in there : https://github.com/Neo23x0/log4shell-detector/blob/main/log4shell-detector.py#L35 |
Can i suggest that instead of looking for the string outright... a more foolproof way to handle the base64 is to actually do the decode. Because the issue is you can base64 encode any subset of the URI and combine it with other chars. So to handle this you could find all of the ${base64:} instances first, decode them, then run back through the detection. |
Could you explain why we would need more coverage with an example? |
You can do this as an example.. encode only "di" ${jn${base64:JZGk}://} or this ... encode just the "d" ${jn${base64:ZA}i://} or... any number of combinations of things that are part of the string I have a PR #25 that adds the decoding |
Ah, I see - yes, good to cover that as well |
FYI, |
I request to add pattern
${base64:JHtqbmRp
which is evaluated to${jndi
. I think with the current algorithm, the detector can not detect these kind of patterns.Ref
https://github.com/SigmaHQ/sigma/blob/master/rules/web/web_cve_2021_44228_log4j_fields.yml#L40
The text was updated successfully, but these errors were encountered: