From 6f93a016201e3c729da5fdc6deaff4f732c0cf3d Mon Sep 17 00:00:00 2001 From: Frank Naegler Date: Wed, 13 Apr 2016 11:04:57 +0200 Subject: [PATCH] [BUGFIX] Fix broken unit tests --- Tests/Unit/Commands/ReviewCommandTest.php | 24 +++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/Tests/Unit/Commands/ReviewCommandTest.php b/Tests/Unit/Commands/ReviewCommandTest.php index 09148ca..4de10c0 100644 --- a/Tests/Unit/Commands/ReviewCommandTest.php +++ b/Tests/Unit/Commands/ReviewCommandTest.php @@ -30,11 +30,11 @@ class ReviewCommandTest extends BaseCommandTestCase public function showTestDataProvider() { return array( - 'review:show 12345' => array('12345'), - 'review:show http://review.typo3.org/#/c/12345/' => array('http://review.typo3.org/#/c/12345/'), - 'review:show https://review.typo3.org/#/c/12345/' => array('https://review.typo3.org/#/c/12345/'), - 'review:show http://review.typo3.org/#/c/12345/1' => array('http://review.typo3.org/#/c/12345/1'), - 'review:show https://review.typo3.org/#/c/12345/1' => array('https://review.typo3.org/#/c/12345/1'), + 'review:show 47640' => array('47640'), + 'review:show http://review.typo3.org/#/c/47640/' => array('http://review.typo3.org/#/c/47640/'), + 'review:show https://review.typo3.org/#/c/47640/' => array('https://review.typo3.org/#/c/47640/'), + 'review:show http://review.typo3.org/#/c/47640/1' => array('http://review.typo3.org/#/c/47640/1'), + 'review:show https://review.typo3.org/#/c/47640/1' => array('https://review.typo3.org/#/c/47640/1'), ); } @@ -160,7 +160,7 @@ public function processShowReturnsCorrectOutputForValidRefIds($refId) $attachments = $result->getAttachments(); /** @var Message\Attachment $attachment */ foreach ($attachments as $attachment) { - static::assertEquals('[BUGFIX] Log route values if a route can\'t be resolved', $attachment->getTitle()); + static::assertEquals('[BUGFIX] Prevent fatal error when uploading file with invalid filename', $attachment->getTitle()); } } @@ -171,14 +171,14 @@ public function processShowReturnsCorrectOutputForMultipleValidRefIds() { $this->initCommandWithPayload(ReviewCommand::class, [ 'user' => 'U54321', - 'text' => 'review:show 12345 23456', + 'text' => 'review:show 47640 23456', ]); /** @var Message $result */ $result = $this->command->process(); - $expectedString = '*[BUGFIX] Cast autoload and classAliasMap to Array* ' - .''.chr(10); - $expectedString .= '*[BUGFIX] Log route values if a route can\'t be resolved* ' - .''; + $expectedString = '*[BUGFIX] Prevent fatal error when uploading file with invalid filename* ' + .''.chr(10); + $expectedString .= '*[BUGFIX] Cast autoload and classAliasMap to Array* ' + .''; static::assertEquals($expectedString, $result); } @@ -330,7 +330,7 @@ public function processShowWithProjectPhasesReturnsCorrectPretext($projectPhase, $this->initCommandWithPayload(ReviewCommand::class, [ 'user' => 'U54321', - 'text' => 'review:show 12345', + 'text' => 'review:show 47640', ]); /** @var Message $result */ $result = $this->command->process();