Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner is blinking while typing in commit #1553

Open
nickkadutskyi opened this issue Nov 8, 2024 · 7 comments
Open

Spinner is blinking while typing in commit #1553

nickkadutskyi opened this issue Nov 8, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@nickkadutskyi
Copy link

Description

When I start committing spinner sows up where is my statusline and on each character it blinks like this:

CleanShot.2024-11-08.at.11.57.03.mp4

After looking at #1551 to resolve the issue I added process_spinner = false.

Neovim version

NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1713773202

Operating system and version

macOS 15.1

Steps to reproduce

  1. Start commit
  2. Type message

Expected behavior

Spinner is not blinking

Actual behavior

Spinner is blinking

Minimal config

-- NOTE: See the end of this file if you are reporting an issue, etc. Ignore all the "scary" functions up top, those are
-- used for setup and other operations.
local M = {}

local base_root_path = vim.fn.fnamemodify(debug.getinfo(1, "S").source:sub(2), ":p:h") .. "/.min"
function M.root(path)
  return base_root_path .. "/" .. (path or "")
end

function M.load_plugin(plugin_name, plugin_url)
  local package_root = M.root("plugins/")
  local install_destination = package_root .. plugin_name
  vim.opt.runtimepath:append(install_destination)

  if not vim.loop.fs_stat(package_root) then
    vim.fn.mkdir(package_root, "p")
  end

  if not vim.loop.fs_stat(install_destination) then
    print(string.format("> Downloading plugin '%s' to '%s'", plugin_name, install_destination))
    vim.fn.system({
      "git",
      "clone",
      "--depth=1",
      plugin_url,
      install_destination,
    })
    if vim.v.shell_error > 0 then
      error(string.format("> Failed to clone plugin: '%s' in '%s'!", plugin_name, install_destination),
        vim.log.levels.ERROR)
    end
  end
end

---@alias PluginName string The plugin name, will be used as part of the git clone destination
---@alias PluginUrl string The git url at which a plugin is located, can be a path. See https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols for details
---@alias MinPlugins table<PluginName, PluginUrl>

---Do the initial setup. Downloads plugins, ensures the minimal init does not pollute the filesystem by keeping
---everything self contained to the CWD of the minimal init file. Run prior to running tests, reproducing issues, etc.
---@param plugins? table<PluginName, PluginUrl>
function M.setup(plugins)
  vim.opt.packpath = {}                      -- Empty the package path so we use only the plugins specified
  vim.opt.runtimepath:append(M.root(".min")) -- Ensure the runtime detects the root min dir

  -- Install required plugins
  if plugins ~= nil then
    for plugin_name, plugin_url in pairs(plugins) do
      M.load_plugin(plugin_name, plugin_url)
    end
  end

  vim.env.XDG_CONFIG_HOME = M.root("xdg/config")
  vim.env.XDG_DATA_HOME = M.root("xdg/data")
  vim.env.XDG_STATE_HOME = M.root("xdg/state")
  vim.env.XDG_CACHE_HOME = M.root("xdg/cache")

  -- NOTE: Cleanup the xdg cache on exit so new runs of the minimal init doesn't share any previous state, e.g. shada
  vim.api.nvim_create_autocmd("VimLeave", {
    callback = function()
      vim.fn.system({
        "rm",
        "-r",
        "-f",
        M.root("xdg")
      })
    end
  })
end

-- NOTE: If you have additional plugins you need to install to reproduce your issue, include them in the plugins
-- table within the setup call below.
M.setup({
  plenary = "https://github.com/nvim-lua/plenary.nvim.git",
  telescope = "https://github.com/nvim-telescope/telescope.nvim",
  diffview = "https://github.com/sindrets/diffview.nvim",
  neogit = "https://github.com/NeogitOrg/neogit"
})
-- WARN: Do all plugin setup, test runs, reproductions, etc. AFTER calling setup with a list of plugins!
-- Basically, do all that stuff AFTER this line.
require("neogit").setup({
                signs = {
                    -- { CLOSED, OPENED }
                    hunk = { "", "" },
                    item = { "", "" },
                    section = { "", "" },
                },
                status = {
                    mode_padding = 2,
                    -- adds whitespace to the left of the mode text to put it further from sings and makes it shorter
                    mode_text = {
                        M = " mod",
                        N = " new",
                        A = " add",
                        D = " del",
                        C = " cop",
                        U = " upd",
                        R = " ren",
                        DD = " unm",
                        AU = " unm",
                        UD = " unm",
                        UA = " unm",
                        DU = " aunm",
                        AA = " unm",
                        UU = " unm",
                        ["?"] = " ",
                    },
                },

}) -- For instance, setup Neogit
@nickkadutskyi nickkadutskyi added the bug Something isn't working label Nov 8, 2024
@etrnal70
Copy link

etrnal70 commented Nov 9, 2024

Imho for such progress indicator, it will be much better to somehow hook this into something like LSP progress rather than a separate spinner

Or at least, neogit can provide status on the git progress and user can make their own progress status integration with their statusline similar to overseer(?)

@nickkadutskyi
Copy link
Author

Integration with fidget or lualine or api to do it myself would definitely be nice.

@ThorstenRhau
Copy link

I have also noticed this annoying aspect of this good plugin. Could we get an option to disable this please?

@CKolkey
Copy link
Member

CKolkey commented Dec 19, 2024

I have also noticed this annoying aspect of this good plugin. Could we get an option to disable this please?

progress_spinner = false :)

@troyfischer
Copy link

fwiw I have a similar blinking cursor issue but only when I open the commit buffer while in neovim inside of zellij

@troyfischer
Copy link

troyfischer commented Dec 21, 2024

I have also noticed this annoying aspect of this good plugin. Could we get an option to disable this please?

progress_spinner = false :)

it's actually process_spinner = false

@CKolkey
Copy link
Member

CKolkey commented Dec 21, 2024

Oops, thanks 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants