Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(h5): InnerAudioContext和BackgroundAudioManager出现错误时未触发onError #14113

Merged
merged 3 commits into from
Jul 10, 2023
Merged

fix(h5): InnerAudioContext和BackgroundAudioManager出现错误时未触发onError #14113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
140802a
fix(h5): InnerAudioContext和BackgroundAudioManager出现错误时未触发onError
tangbzai Jul 4, 2023
7d921c0
Merge branch 'next' into fixbug/h5-audio-onError
ZakaryCode Jul 10, 2023
61f3f53
Merge branch 'next' into fixbug/h5-audio-onError
ZakaryCode Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/taro-h5/src/api/media/audio/InnerAudioContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export class InnerAudioContext implements Taro.InnerAudioContext {
this.Instance = new Audio()
this.errorStack = new CallbackManager()
this.stopStack = new CallbackManager()
this.Instance.onerror = this.errorStack.trigger

Taro.eventCenter.on('__taroRouterChange', () => { this.stop() })
this.onPlay(() => {
Expand Down
1 change: 1 addition & 0 deletions packages/taro-h5/src/api/media/background-audio/BackgroundAudioManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export class BackgroundAudioManager implements Taro.BackgroundAudioManager {
this.Instance = new Audio()
this.errorStack = new CallbackManager()
this.stopStack = new CallbackManager()
this.Instance.onerror = this.errorStack.trigger
this.Instance.autoplay = true
this.onPlay(() => {
if (this.currentTime !== this.startTime) {
Expand Down