Does not build on FreeBSD 12

[mikeowens]

# wget https://github.com/NetBSDfr/pkgin/archive/v0.13.0.tar.gz
# tar xzvf v0.13.0.tar.gz
# cd pkgin-0.13.0/
# /configure --prefix=/usr/local
checking build system type... x86_64-unknown-freebsd12.0
checking host system type... x86_64-unknown-freebsd12.0
checking for gcc... no
checking for cc... cc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether cc accepts -g... yes
checking for cc option to accept ISO C89... none needed
checking how to run the C preprocessor... cc -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking minix/config.h usability... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking whether we are using the GNU C compiler... (cached) yes
checking whether cc accepts -g... (cached) yes
checking for cc option to accept ISO C89... (cached) none needed
checking for a BSD-compatible install... /usr/bin/install -c
checking for dup2... yes
checking for getcwd... yes
checking for localeconv... yes
checking for memmove... yes
checking for memset... yes
checking for mkdir... yes
checking for putenv... yes
checking for regcomp... yes
checking for rmdir... yes
checking for setenv... yes
checking for strcasecmp... yes
checking for strchr... yes
checking for strcspn... yes
checking for strdup... yes
checking for strncasecmp... yes
checking for strpbrk... yes
checking for strrchr... yes
checking for strstr... yes
checking for strtol... yes
checking for freopen... yes
checking for tcgetpgrp... yes
checking for pthread_create... no
checking for pthread_create in -lpthread... yes
checking for humanize_number... no
checking for library containing humanize_number... -lutil
checking for library containing socket... none required
checking for library containing inet_addr... none required
checking for strlcpy in -lnbcompat... no
checking for library containing fetchGetURL... -lfetch
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking for inttypes.h... (cached) yes
checking limits.h usability... yes
checking limits.h presence... yes
checking for limits.h... yes
checking locale.h usability... yes
checking locale.h presence... yes
checking for locale.h... yes
checking netdb.h usability... yes
checking netdb.h presence... yes
checking for netdb.h... yes
checking for stdint.h... (cached) yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking sys/file.h usability... yes
checking sys/file.h presence... yes
checking for sys/file.h... yes
checking sys/param.h usability... yes
checking sys/param.h presence... yes
checking for sys/param.h... yes
checking sys/statvfs.h usability... yes
checking sys/statvfs.h presence... yes
checking for sys/statvfs.h... yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking for unistd.h... (cached) yes
checking sys/queue.h usability... yes
checking sys/queue.h presence... yes
checking for sys/queue.h... yes
checking ctype.h usability... yes
checking ctype.h presence... yes
checking for ctype.h... yes
checking stdio.h usability... yes
checking stdio.h presence... yes
checking for stdio.h... yes
checking assert.h usability... yes
checking assert.h presence... yes
checking for assert.h... yes
checking err.h usability... yes
checking err.h presence... yes
checking for err.h... yes
checking stdarg.h usability... yes
checking stdarg.h presence... yes
checking for stdarg.h... yes
checking sys/wait.h usability... yes
checking sys/wait.h presence... yes
checking for sys/wait.h... yes
checking errno.h usability... yes
checking errno.h presence... yes
checking for errno.h... yes
checking dirent.h usability... yes
checking dirent.h presence... yes
checking for dirent.h... yes
checking regex.h usability... yes
checking regex.h presence... yes
checking for regex.h... yes
checking sys/poll.h usability... yes
checking sys/poll.h presence... yes
checking for sys/poll.h... yes
checking sys/signal.h usability... yes
checking sys/signal.h presence... yes
checking for sys/signal.h... yes
checking signal.h usability... yes
checking signal.h presence... yes
checking for signal.h... yes
checking termcap.h usability... yes
checking termcap.h presence... yes
checking for termcap.h... yes
checking fnmatch.h usability... yes
checking fnmatch.h presence... yes
checking for fnmatch.h... yes
checking sys/utsname.h usability... yes
checking sys/utsname.h presence... yes
checking for sys/utsname.h... yes
checking nbcompat.h usability... no
checking nbcompat.h presence... no
checking for nbcompat.h... no
checking nbcompat/string.h usability... no
checking nbcompat/string.h presence... no
checking for nbcompat/string.h... no
checking util.h usability... no
checking util.h presence... no
checking for util.h... no
checking bsd/libutil.h usability... no
checking bsd/libutil.h presence... no
checking for bsd/libutil.h... no
checking libutil.h usability... yes
checking libutil.h presence... yes
checking for libutil.h... yes
checking sys/termios.h usability... yes
checking sys/termios.h presence... yes
checking for sys/termios.h... yes
checking termios.h usability... yes
checking termios.h presence... yes
checking for termios.h... yes
checking sys/cdefs.h usability... yes
checking sys/cdefs.h presence... yes
checking for sys/cdefs.h... yes
checking for int64_t... yes
checking for pid_t... yes
checking for size_t... yes
checking for ssize_t... yes
checking for uint16_t... yes
checking for uint64_t... yes
checking for uint8_t... yes
checking for struct stat.st_mtimespec.tv_nsec... yes
checking for struct stat.st_mtim.tv_nsec... yes
checking for struct stat.st_mtime_n... no
checking for struct stat.st_umtime... no
checking for struct stat.st_mtime_usec... no
checking for nbsed... sed
configure: creating ./config.status
config.status: creating Makefile
config.status: creating config.h

# ls /usr/local/include/sqlite3*
/usr/local/include/sqlite3.h    /usr/local/include/sqlite3ext.h
# make
--- pkgindb_create.h ---
--- objwarn ---
Warning: Object directory not changed from original /var/data/tmp/pkgin-0.13.0
--- .depend ---
echo pkgin.full: /usr/lib/libc.a  >> .depend
--- main.o ---
--- summary.o ---
--- tools.o ---
--- pkgindb.o ---
--- main.o ---
cc  -O2 -pipe   -g -MD  -MF.depend.main.o -MTmain.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable  -Qunused-arguments  -c main.c -o main.o
--- summary.o ---
cc  -O2 -pipe   -g -MD  -MF.depend.summary.o -MTsummary.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable  -Qunused-arguments  -c summary.c -o summary.o
--- tools.o ---
cc  -O2 -pipe   -g -MD  -MF.depend.tools.o -MTtools.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable  -Qunused-arguments  -c tools.c -o tools.o
--- pkgindb.o ---
cc  -O2 -pipe   -g -MD  -MF.depend.pkgindb.o -MTpkgindb.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable  -Qunused-arguments  -c pkgindb.c -o pkgindb.o
pkgindb.c:30:10: fatal error: 'sqlite3.h' file not found
#include <sqlite3.h>
         ^~~~~~~~~~~
--- tools.o ---
In file included from tools.c:30:
./tools.h:81:10: fatal error: 'nbcompat/util.h' file not found
#include <nbcompat/util.h>
         ^~~~~~~~~~~~~~~~~
--- summary.o ---
In file included from summary.c:34:
./tools.h:81:10: fatal error: 'nbcompat/util.h' file not found
#include <nbcompat/util.h>
         ^~~~~~~~~~~~~~~~~
--- tools.o ---
1 error generated.
*** [tools.o] Error code 1

make: stopped in /var/data/tmp/pkgin-0.13.0
--- main.o ---
In file included from main.c:30:
In file included from ./pkgin.h:42:
/usr/include/fetch.h:46:14: error: use of undeclared identifier 'MAXHOSTNAMELEN'
        char             host[MAXHOSTNAMELEN+1];
                              ^
/usr/include/fetch.h:62:14: error: use of undeclared identifier 'PATH_MAX'
        char             name[PATH_MAX];
                              ^
In file included from main.c:30:
In file included from ./pkgin.h:46:
./tools.h:81:10: fatal error: 'nbcompat/util.h' file not found
#include <nbcompat/util.h>
         ^~~~~~~~~~~~~~~~~
--- pkgindb.o ---
1 error generated.
--- main.o ---
3 errors generated.
--- pkgindb.o ---
*** [pkgindb.o] Error code 1

make: stopped in /var/data/tmp/pkgin-0.13.0
--- main.o ---
*** [main.o] Error code 1

make: stopped in /var/data/tmp/pkgin-0.13.0
--- summary.o ---
1 error generated.
*** [summary.o] Error code 1

make: stopped in /var/data/tmp/pkgin-0.13.0
4 errors

make: stopped in /var/data/tmp/pkgin-0.13.0

[jperkin]

Same as #74, the eventual goal is to have pkgin be fully portable and build outside of the pkgsrc environment across lots of OS, but this will take a while and isn't a high priority at the moment.

The libfetch failure here is the same as #74, and at least with recent versions of pkgin you will get a configure failure due to missing libnbcompat rather than a build-time failure.

Of course if pkgin fails to build on FreeBSD within pkgsrc then that would be a high priority issue, but I'm assuming it builds fine as it does on DragonFly?