Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add more consistency checks before upgrading #93

Open
0-wiz-0 opened this issue Jun 16, 2020 · 2 comments
Open

Please add more consistency checks before upgrading #93

0-wiz-0 opened this issue Jun 16, 2020 · 2 comments
Assignees

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Jun 16, 2020

I had a partially successful bulk build and decided to use the result anyway for updating (yes, my fault. But when you're using someone else's bulk build you don't know if it's complete or what did not build).
In particular, this upgraded libicu with a shlib major bump.
After the upgrade (pkgin fug) which went without obvious errors or non-standard questions, many packages that had failed in the last bulk would not run any longer, because they depended on the old libicu shared library which was replaced by the new one during the upgrade.

This could have been prevented if pkgin had notified me that packages foo, bar, baz would not resolve their library dependencies any longer after the upgrade and asked for confirmation (then I would have cancelled it).

Please add a check and confirmation dialog for that case. Thanks!

@jperkin jperkin self-assigned this Aug 10, 2020
@jperkin
Copy link
Contributor

jperkin commented Aug 10, 2020

I'll take a look. This may end up being a little expensive to check, and needs to be done carefully to ensure we still retain checks for files that are not managed by the current target pkgsrc installation.

Obviously not using broken repositories is preferable ;) But I can see that this would be useful in any case.

@jperkin
Copy link
Contributor

jperkin commented Aug 10, 2020

(Also sorry, somehow I wasn't watching this repository until today, so only just noticed it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants