Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't resolve local download path when generating appcast with -u parameter #399

Closed
giacarrea opened this issue Nov 21, 2022 · 2 comments · Fixed by #620
Closed

Can't resolve local download path when generating appcast with -u parameter #399

giacarrea opened this issue Nov 21, 2022 · 2 comments · Fixed by #620

Comments

@giacarrea
Copy link

Excerpt from my issue posted on gitter:

I tried to generate an appcast with the download URL's set to "../", then put the appcast in its own directory on my server, but then, while the library did manage to parse the appcast correctly and locate the proper url to download my installer, the library then couldn't resolve the directory to download the file to
Output log:

netsparkle: Starting to download ../Myocene_0.5.1.0-Installer.exe to
netsparkle: IUpdateDownloader: Starting file download from http://localhost/testNetSparkle/Myocene_0.5.1.0-Installer.exe to
Exception thrown: 'System.ArgumentNullException' in System.Private.CoreLib.dll
netsparkle: Error: Path cannot be null. (Parameter 'path')
netsparkle: Download was canceled

I tried to force a value to the tmpdownladfilepath property of my updater object (even tough my regular file works fine), but that didn't change anything

@Deadpikle Deadpikle added the bug label Nov 21, 2022
@Deadpikle
Copy link
Collaborator

Deadpikle commented Dec 18, 2022

Hm, looks like the download file name isn't right. See the first line of the output log.

Have you tried setting CheckServerFileName to false just to try that? Might need to debug in the GetDownloadPathForAppCastItem function to see why it's returning something blank, as perhaps the code isn't able to grab the filename for some reason. 🤔

(I haven't the time this moment to sit down and actually debug this myself. Sorry about that. Thank you for logging this on GitHub so we can track the issue.)

@Deadpikle
Copy link
Collaborator

This is fixed in #620 which will be merged to develop in once CI verifies that all still works OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants