Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConcatenatedTransform.Inverse() method destroys the state of child transformations #10

Closed
Nipheris opened this issue Nov 4, 2015 · 3 comments

Comments

@Nipheris
Copy link

Nipheris commented Nov 4, 2015

The bug is related to ConcatenatedTransform.Inverse() method, which has unexpected side effects on child transformations in the list. Because of the absense of deep cloning of child transformations in Clone(), the call of Invert() method on the cloned ConcatenatedTransform object leads to subsequent calls of Invert() on the original child transformations.

To fix this I suggest to reimplement ConcatenatedTransform.Inverse() method to make him create the new ConcatenatedTransform object from the subsequent calls of Inverse() on child transforms (not Invert()).

@FObermaier
Copy link
Member

A unit test to prove your point and a patch file would be great.

@Nipheris
Copy link
Author

Nipheris commented Nov 4, 2015

Sure, I will fork the repo a bit later, and will provide fix and testcase.

@Nipheris
Copy link
Author

Nipheris commented Mar 8, 2019

Magnificent!! You fixed this! Thanks a lot!

Time to throw away our nasty workarounds 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants