More work on HystrixCollapser response not received bug #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still can't replicate this so am adding error handling anywhere I can foresee something as well as adding more logs. #80
benjchristensen
added a commit
that referenced
this pull request
Feb 23, 2013
More work on HystrixCollapser response not received bug
| } else { | ||
| logger.error("TimedOut waiting on responseReference: " + responseReceived.getCount() + " batchReceived: " + batchReceived.getCount() + " batchFuture: " + batchFuture + " batchFuture.isDone: " + batchFuture.isDone() + " batchFuture.isCancelled: " + batchFuture.isCancelled() + " argument: " + argument); | ||
| } | ||
| throw new ExecutionException("No response or exception set before returning from Future.get", new NullPointerException("ResponseReference is NULL")); |
There was a problem hiding this comment.
Would something besides NullPointerException make sense? Or is this case basically a bug so calling code shouldn't think about handling it?
There was a problem hiding this comment.
It's a bug and should never happen which is what I'm trying to track down.
I'm deploying debug builds into a production canary to try and determine how this happens as I can't replicate it outside of production.
|
Thanks for this. We'll try this out in prod next week and see if it helps or at least gives us some more info. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still can't replicate this so am adding error handling anywhere I can foresee something as well as adding more logs.
#80