Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection closing and content stream behavior #250

Closed
NiteshKant opened this issue Oct 22, 2014 · 0 comments
Closed

Connection closing and content stream behavior #250

NiteshKant opened this issue Oct 22, 2014 · 0 comments
Assignees
@NiteshKant
Milestone
0.3.15

Comments

@NiteshKant
Copy link
Member

For HTTP, on closing a connection (server or client), the associated HTTP content stream (request content for server and response content for client) is sent an onComplete(). This behavior should be modified as follows:

  • If the request/response is not complete (we have not yet received LastHttpContent) at the time of connection close, it should result in invoking onError on the content stream. This is required as not doing so will result in clients/servers receiving incomplete content.
  • If the request/response is completed, there is no change required.

The current behavior also results in wrong metrics on inflightRequests
@NiteshKant NiteshKant self-assigned this Oct 22, 2014
@NiteshKant NiteshKant added this to the 0.3.15 milestone Oct 22, 2014
NiteshKant pushed a commit to NiteshKant/RxNetty that referenced this issue Oct 22, 2014
Fixes ReactiveX#248 ReactiveX#249 ReactiveX#250 ReactiveX#251
a0dea00 
ReactiveX#248 (Connection close cancels pending writes): Now only cancelling when a pooled connection is returned to the pool.
ReactiveX#249 (`BytesInspector` does not record events for `ByteBufHolder` and `FileRegion`): Recording events for ByteBufHolder and FileRegion
ReactiveX#250 (Connection closing and content stream behavior): Send error on content stream if the request/response is not completed on server/client.
ReactiveX#251 (Metric events for Request content source error and request write failure): Added metrics
@NiteshKant NiteshKant mentioned this issue Oct 23, 2014
Merged
@NiteshKant NiteshKant mentioned this issue Oct 30, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NiteshKant NiteshKant

Labels
None yet
Projects
None yet
Milestone
0.3.15
Development

No branches or pull requests
1 participant
@NiteshKant