Use IntUnaryOperator in Gradient2Limit for queueSize #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umairk79
reviewed
Sep 17, 2024
concurrency-limits-core/src/main/java/com/netflix/concurrency/limits/limit/Gradient2Limit.java
Show resolved
Hide resolved
kilink
force-pushed
the
gradient2-limit-int-unary-operator
branch
from
2483e71
to
c4ec2c4
Compare
Use IntUnaryOperator in Gradient2Limit for queueSize to avoid boxing. Also, avoid excessive volatile reads and avoid boxing when debug logging is disabled.
kilink
force-pushed
the
gradient2-limit-int-unary-operator
branch
from
c4ec2c4
to
26f23a0
Compare
umairk79
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use IntUnaryOperator in Gradient2Limit for queueSize to avoid boxing. Also, avoid excessive volatile reads and avoid boxing when debug logging is disabled.