Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return singleton no-op Listener in createBypassListener #209

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Return singleton no-op Listener in createBypassListener #209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 16 additions & 17 deletions ...ncy-limits-core/src/main/java/com/netflix/concurrency/limits/limiter/AbstractLimiter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,21 @@
public abstract class AbstractLimiter<ContextT> implements Limiter<ContextT> {
public static final String ID_TAG = "id";
public static final String STATUS_TAG = "status";
private static final Listener NOOP_LISTENER = new Listener() {
@Override
public void onSuccess() {
}
@Override
public void onIgnore() {
}
@Override
public void onDropped() {
}
@Override
public String toString() {
return "{NoopListener}";
}
};

public abstract static class Builder<BuilderT extends Builder<BuilderT>> {
private static final AtomicInteger idCounter = new AtomicInteger();
Expand Down Expand Up @@ -128,23 +143,7 @@ protected Optional<Listener> createRejectedListener() {

protected Optional<Listener> createBypassListener() {
this.bypassCounter.increment();
return Optional.of(new Listener() {

@Override
public void onSuccess() {
// Do nothing
}

@Override
public void onIgnore() {
// Do nothing
}

@Override
public void onDropped() {
// Do nothing
}
});
return Optional.of(NOOP_LISTENER);
}

protected Listener createListener() {
Expand Down
Loading