Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstracting away SubcommandManager's signal handling #2057

Open
filipcacky opened this issue Sep 24, 2024 · 0 comments
Open

Abstracting away SubcommandManager's signal handling #2057

filipcacky opened this issue Sep 24, 2024 · 0 comments

Comments

@filipcacky
Copy link
Contributor

filipcacky commented Sep 24, 2024

Currently, SubprocessManager and by extension Runner and Deployer hook an interrupt signal handler via either signal or asyncio. This is slightly problematic when integrating metaflow with an existing codebase, which already does its own signal handling, because both registering a signal with either asyncio or signal overrides any previously set signal handler.

I propose abstracting away the hook in SubprocessManager to a new class SignalManager and allowing users to supply their own instance of it to Deployer and Runner. This would be a non-breaking change.

Adding a POC impl in PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant