-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spectator-reg-atlas POM file has wrong packaging type since 1.7.5 #1113
Comments
@rpalcolea @chali are either of you familiar with how the packaging gets setup for the POM when publishing only the shadow jar? I'm guessing this has to do with #1103 or #1104. |
Hi, Let me add some details to this. The project can be reproduced by Micrometer's build but I can also repro it with a minimal Gradle project: apply plugin: 'java'
repositories {
mavenCentral()
}
dependencies {
implementation 'com.netflix.spectator:spectator-reg-atlas:1.7.6'
} And you can try to use it in a simple Java class (e.g.: package org.example;
public class App {
public static void main(String[] args) {
com.netflix.spectator.atlas.AtlasConfig atlasConfig = null;
}
} Which should result in the same compiler error as above:
I used the latest Gradle (
I don't think the java version or the OS is related since we have this issue on Micrometer CI too (Linux with different Java versions). If I use Atlas
If I use
|
Hi folks, I suspect there might be a regression in that fork. I opened #1114 which:
|
Thanks, I'll try out your patch. Since the fork is just the original project with recent changes added, it might be good to understand what the regression is. If the original starts getting updated again it seems likely it would pick up the same regression. |
@jonatan-ivanov 1.7.7 has been released and it works with micrometer when I tried locally. |
Thank you! 1.7.7 passes on CI too I'm going to upgrade on Monday. |
It was inadvertently changed to
<packaging>pom</packaging>
in 1.7.5 causing some problems for some projects trying to pull it in, for example micrometer-metrics/micrometer#4700.The text was updated successfully, but these errors were encountered: