Add test

NethermindEth · Apr 3, 2024 · 5321be7 · 5321be7
1 parent 0db20e1
commit 5321be7
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/Nethermind/Nethermind.Network.Test/P2P/Subprotocols/Eth/V68/Eth68ProtocolHandlerTests.cs b/src/Nethermind/Nethermind.Network.Test/P2P/Subprotocols/Eth/V68/Eth68ProtocolHandlerTests.cs
@@ -175,7 +175,25 @@ public void should_send_up_to_MaxCount_hashes_in_one_NewPooledTransactionHashesM
 
         _handler.SendNewTransactions(txs, false);
 
-        _session.Received(1).DeliverMessage(Arg.Is<NewPooledTransactionHashesMessage68>(m => m.Hashes.Count == txCount));
+        _session.Received(1).DeliverMessage(Arg.Is<NewPooledTransactionHashesMessage68>(m =>
+            m.Hashes.Count == txCount &&
+            m.Sizes.Count == txCount &&
+            m.Types.Count == txCount));
+    }
+
+    [Test]
+    public void should_send_blob_tx_announcement_in_NewPooledTransactionHashesMessage68()
+    {
+        Transaction tx = Build.A.Transaction.WithNonce((UInt256)0).WithShardBlobTxTypeAndFields().SignedAndResolved().TestObject;
+
+        _handler.SendNewTransaction(tx);
+
+        _session.Received(1).DeliverMessage(Arg.Is<NewPooledTransactionHashesMessage68>(m =>
+            m.Hashes.Count == 1 &&
+            m.Sizes.Count == 1 &&
+            m.Types.Count == 1 &&
+            m.Hashes[0] == tx.Hash &&
+            (TxType)m.Types[0] == tx.Type));
     }
 
     [TestCase(NewPooledTransactionHashesMessage68.MaxCount - 1)]

diff --git a/src/Nethermind/Nethermind.Network/P2P/ProtocolHandlers/SyncPeerProtocolHandlerBase.cs b/src/Nethermind/Nethermind.Network/P2P/ProtocolHandlers/SyncPeerProtocolHandlerBase.cs
@@ -17,7 +17,6 @@
 using Nethermind.Core.Extensions;
 using Nethermind.Int256;
 using Nethermind.Logging;
-using Nethermind.Network.P2P.Messages;
 using Nethermind.Network.P2P.Subprotocols.Eth.V62;
 using Nethermind.Network.P2P.Subprotocols.Eth.V62.Messages;
 using Nethermind.Network.P2P.Subprotocols.Eth.V63.Messages;
@@ -208,6 +207,7 @@ public virtual Task<IOwnedReadOnlyList<byte[]>> GetNodeData(IReadOnlyList<Hash25
 
         private bool ShouldNotifyTransaction(Hash256? hash) => hash is not null && NotifiedTransactions.Set(hash);
 
+
         public void SendNewTransaction(Transaction tx)
         {
             if (ShouldNotifyTransaction(tx.Hash))