Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eth_blobGasPrice/eth_gasPrices; update eth_feeHistory #6563

Merged
merged 12 commits into from
Feb 26, 2024
Merged

Add eth_blobGasPrice/eth_gasPrices; update eth_feeHistory #6563

merged 12 commits into from
Feb 26, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Jan 18, 2024 •
edited
Loading

Implements ethereum/execution-apis#486

Changes

  • Add eth_blobBaseFee
  • Update eth_feeHistory with blob fields

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@flcl42 flcl42 marked this pull request as ready for review February 19, 2024 11:26
benaadams
benaadams approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@benaadams benaadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any hive tests for this?

@flcl42
Copy link
Contributor Author

flcl42 commented Feb 26, 2024

Any hive tests for this?

Not yet

@flcl42 flcl42 merged commit 8c7336b into master Feb 26, 2024
67 checks passed
@flcl42 flcl42 deleted the feature/blob-price branch February 26, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@marcindsobczak marcindsobczak marcindsobczak approved these changes

@benaadams benaadams benaadams approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

@smartprogrammer93 smartprogrammer93 Awaiting requested review from smartprogrammer93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flcl42 @benaadams @LukaszRozmej @marcindsobczak