Compact dbs manually #6595
Merged
Compact dbs manually #6595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flcl42
requested review from
asdacap,
LukaszRozmej,
kamilchodola,
marcindsobczak and
damian-orzechowski
| @@ -55,6 +58,10 @@ private void CleanProcessedTransactionsDb(long newlyFinalizedBlockNumber) | |||
|
|
|||
| if (_logger.IsDebug) _logger.Debug($"Cleaned processed blob txs from block {_lastFinalizedBlock} to block {newlyFinalizedBlockNumber}"); | |||
|
|
|||
| _db.Compact(); | |||
There was a problem hiding this comment.
Can we guard the compaction not use to many resources? (Threads? I/O?) So it won't starve anything else in block processing.
| @@ -55,6 +58,10 @@ private void CleanProcessedTransactionsDb(long newlyFinalizedBlockNumber) | |||
|
|
|||
| if (_logger.IsDebug) _logger.Debug($"Cleaned processed blob txs from block {_lastFinalizedBlock} to block {newlyFinalizedBlockNumber}"); | |||
|
|
|||
| _db.Compact(); | |||
There was a problem hiding this comment.
Shall we only run compaction only after enough transactions were deleted from the db? Put some threshold?
LukaszRozmej
approved these changes
Jan 23, 2024
marcindsobczak
approved these changes
Jan 28, 2024
flcl42
force-pushed
the
cleanup-blobs-db
branch
5 times, most recently
from
65b3a67
to
bfd91b5
Compare
flcl42
force-pushed
the
cleanup-blobs-db
branch
from
bfd91b5
to
a55635d
Compare
|
It takes 1-3 seconds to compact every 6 minutes. Seems OK for now. I'm experimenting with more db options which requires long runs, the only thing that may change is these seconds will be spent by rocksdb in manner opaque for us + maybe less IO spent on compaction. |
MarekM25
pushed a commit
that referenced
this pull request
Feb 6, 2024
(cherry picked from commit d0ed28b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6575
No need in resync; very first compaction may take a while.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?