-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove coupling from merge plugin and aura #7044
Merged
smartprogrammer93
merged 5 commits into
master
from
refactor/remove-coupling-from-merge-plugin-and-aura
Aug 24, 2024
Merged
Remove coupling from merge plugin and aura #7044
smartprogrammer93
merged 5 commits into
master
from
refactor/remove-coupling-from-merge-plugin-and-aura
Aug 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
reviewed
May 22, 2024
MarekM25
reviewed
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we test it with gnosis node and mainnet node?
MarekM25
reviewed
May 22, 2024
src/Nethermind/Nethermind.Merge.AuRa/AuRaMergeFinalizationManager.cs
Outdated
Show resolved
Hide resolved
smartprogrammer93
force-pushed
the
refactor/remove-coupling-from-merge-plugin-and-aura
branch
from
July 1, 2024 10:38
c7536be
to
baa46b2
Compare
smartprogrammer93
force-pushed
the
refactor/remove-coupling-from-merge-plugin-and-aura
branch
2 times, most recently
from
July 16, 2024 09:56
9e0994a
to
acae0d3
Compare
smartprogrammer93
force-pushed
the
refactor/remove-coupling-from-merge-plugin-and-aura
branch
from
August 23, 2024 18:00
acae0d3
to
6e428f9
Compare
LukaszRozmej
approved these changes
Aug 23, 2024
smartprogrammer93
deleted the
refactor/remove-coupling-from-merge-plugin-and-aura
branch
August 24, 2024 17:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs
. Remove if not applicable.Requires explanation in Release Notes