Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coupling from merge plugin and aura #7044

Merged

Conversation

smartprogrammer93
Copy link
Contributor

Changes

  • decouple merge plugin from aura consensus.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we test it with gnosis node and mainnet node?

@smartprogrammer93 smartprogrammer93 force-pushed the refactor/remove-coupling-from-merge-plugin-and-aura branch from c7536be to baa46b2 Compare July 1, 2024 10:38
@smartprogrammer93 smartprogrammer93 force-pushed the refactor/remove-coupling-from-merge-plugin-and-aura branch 2 times, most recently from 9e0994a to acae0d3 Compare July 16, 2024 09:56
@smartprogrammer93 smartprogrammer93 force-pushed the refactor/remove-coupling-from-merge-plugin-and-aura branch from acae0d3 to 6e428f9 Compare August 23, 2024 18:00
@smartprogrammer93
Copy link
Contributor Author

smartprogrammer93 commented Aug 23, 2024

@MarekM25 tested on both Chiado and mainnet here:

@smartprogrammer93 smartprogrammer93 merged commit e856de5 into master Aug 24, 2024
72 checks passed
@smartprogrammer93 smartprogrammer93 deleted the refactor/remove-coupling-from-merge-plugin-and-aura branch August 24, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants