Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce objects used by LruCaching #7100

Merged
merged 8 commits into from
May 28, 2024
Merged

Reduce objects used by LruCaching #7100

merged 8 commits into from
May 28, 2024

Conversation

benaadams
Copy link
Member

Changes

  • The speed of GC is a function of the number of objects allocated (rather than size)
    • Reduce number of objects by 4M by using an array with offsets rather than linked list for Lru
    • Disadvantage is fixed size

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • Yes

If yes, did you write tests?

  • Yes

@benaadams benaadams mentioned this pull request May 28, 2024
Closed
9 tasks
@benaadams benaadams merged commit 6e1ec86 into master May 28, 2024
68 checks passed
@benaadams benaadams deleted the object-count branch May 28, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@asdacap asdacap Awaiting requested review from asdacap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej