-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detailed port-in-use error #7316
Conversation
OpenEthereum had a good config value for this:
Maybe we should add something similar? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to indicate which port conflict resulted in this error.
@LukaszRozmej, it already does, but by port number as you can see in the PR description. I decided to not include specific option name due to some of the calls not having a single port to blame. For example, Regarding showing all port options in the error. Idea was that since the issue is likely to happen due to an attempt to run another instance on the same machine, it would be better to show all the configurable ports, instead of showing a new (failed one) each run. |
@alexb5dh can you resolve conflicts? |
…rt-error # Conflicts: # src/Nethermind/Nethermind.Network.Discovery/DiscoveryApp.cs # src/Nethermind/Nethermind.Network.Discovery/Discv5/DiscoveryV5App.cs
@LukaszRozmej, done |
Changes
Provide details regarding port configuration when binding fails due to port being in use. Example:
Testing
Requires testing
If yes, did you write tests?
Requires explanation in Release Notes