Feature t8n gnosis #7319
Merged
Feature t8n gnosis #7319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilchodola
reviewed
Aug 9, 2024
| { | ||
| TestContext.Write($"Running {test.Name} at {DateTime.UtcNow:HH:mm:ss.ffffff}"); | ||
| Console.WriteLine("Passing over here"); |
dmitriy-b
reviewed
Oct 15, 2024
tools/evm/Program.cs
Outdated
| @@ -36,6 +36,7 @@ static void ConfigureT8NCommand(ref RootCommand rootCmd) | |||
| var traceOpt = new Option<bool>("--trace", description: "Configures the use of the JSON opcode tracer. This tracer emits traces to files as trace-<txIndex>-<txHash>.jsonl", getDefaultValue: () => false); | |||
| var traceNoStackOpt = new Option<bool>("--trace.noStack", description: "Trace no stack", getDefaultValue: () => false); | |||
| var traceReturnDataOpt = new Option<bool>("--trace.returnData", description: "Trace return data", getDefaultValue: () => false); | |||
| var isGnosisTests = new Option<bool>("--run.gnosis", description: "If set to true, will run under Gnosis spec", getDefaultValue: () => false); | |||
There was a problem hiding this comment.
Just an idea for an improvement: instead of using a new --run.gnosis option maybe we can reuse --state.chainId and choose ISpecProvider based on chain / networkid? With such a way we will not need to add a new flag every time we have to add a new network to t8n.
There was a problem hiding this comment.
Good idea, removed --run.gnosis flag
yerke26
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?