-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow other async runtimes such as async-std #26
Comments
If it can be done without changing the API or code clutter than sure. |
No, it can't be done without changing the API. The API directly links to tokio, hence why I suggested a feature flag. I'm not sure what exactly would qualify as code clutter. It depends on how much reliance there is on tokio, and how much of that can be replaced by executor-agnostic async code. Based on a search for |
To clarify: the API would change very little. Only the |
The only things that would need to be modified are the tokio tasks inside |
Feel free to make a PR. However I'd like to mention the external API should remain relatively the same. |
I can make a PR in a bit adding this if you don't want to, as it could be useful in the future. |
I'll be including this in the "v2" (actually 1.x.x) rewrite, as it includes a lot of design improvements from |
Okay, now that everything to my knowledge is 100% working, I will get started on this issue 😄 |
@A248 This issue is now tracking branch |
I'd like to use this library myself, but with async-std rather than Tokio -- my existing code is written against async-std.
Could async-std be supported by a feature flag? I am willing to create a PR if necessary
The text was updated successfully, but these errors were encountered: