Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When running Marabou.cpp - asserts arn't called even with debug mode #226

Closed
Yoni-Mantzur opened this issue Mar 22, 2020 · 2 comments
Closed

When running Marabou.cpp - asserts arn't called even with debug mode #226

Yoni-Mantzur opened this issue Mar 22, 2020 · 2 comments
Assignees
@yuvaljacoby
Labels
bug minor

Comments

@Yoni-Mantzur
Copy link
Collaborator

When running the main module - Marabou.cpp on debug mode, assertions are not called. Probably due to missing --DDEBUG flag
@yuvaljacoby
Copy link
Collaborator

Are you sure clion is adding DEBUG flag? I know that usually NDEBUG is used to indicate release mode (anyway that is what cmake is doing).
I just pushed use_ndebug branch,can you try it out? if it doesn't t work take a look at src/common/Debug.h or late me know

@Yoni-Mantzur
Copy link
Collaborator Author

@yuvaljacoby the fix looks good, tested on debug mode and release mode.

@yuvaljacoby yuvaljacoby mentioned this issue Mar 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuvaljacoby yuvaljacoby

Labels
bug minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuvaljacoby @Yoni-Mantzur